Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: movable point coordX #19

Merged
merged 1 commit into from
May 20, 2024
Merged

Fix: movable point coordX #19

merged 1 commit into from
May 20, 2024

Conversation

Kim716
Copy link

@Kim716 Kim716 commented May 15, 2024 •
edited
Loading

Pull Request Title 請加上 prefix，e.g. New:/Fix:/Change:/Refactor:/Chore:/Test:/Doc: ...

Notion Link:
https://www.notion.so/junyiacademy/number-line-widget-51c64316abb7437294cf1935280c8d55?pvs=4

Introduction

請說明此 Pull Request 的目的

  • 調整 MovablePoint 的行為，code 細節說明見 comment or 註解

How to verify

請說明如何驗證此 Pull Request 的改動可以達成目的（或是做過哪些驗證）

  • 目前盤點有使用到 addMovablePoint 的 widget 只有 plotter，其中有影響的 coordX 是新加的功能才會用到（目前還沒正式開發），之後開發時會留意～

@Kim716 Kim716 self-assigned this May 15, 2024
@Kim716 Kim716 force-pushed the fix/movable-point branch from 88579fd to 8c3f081 Compare May 18, 2024 00:50
@Kim716 Kim716 merged commit 12a4900 into main May 20, 2024
@Kim716 Kim716 added the 🔧 publish-npm Add this tag will publish perseus-core to npm label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esp10mm esp10mm esp10mm approved these changes

Assignees

@Kim716 Kim716

Labels
🔧 publish-npm Add this tag will publish perseus-core to npm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kim716 @esp10mm